Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel fixes #712

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Panel fixes #712

merged 3 commits into from
Oct 24, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 23, 2018 •
edited by jasonrsadler
Loading

Fixes panel favicon
Fixes panel create wallet
Fixes on restart panel show
Fixes panel not clearing after a switch

Resolves brave/brave-browser#1719
Resolves brave/brave-browser#1792
Resolves brave/brave-browser#1777
Resolves brave/brave-browser#1660

Ledger implementation brave-intl/bat-native-ledger#154

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • go to one site
  • click on BAT logo
  • click join now
  • make sure that you see publisher data of the site that you are currently on
  • restart browser
  • click on BAT logo
  • make sure that you see publisher data of the site that you are currently on

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Oct 23, 2018
@NejcZdovc NejcZdovc mentioned this pull request Oct 23, 2018
Merged
@NejcZdovc NejcZdovc force-pushed the create-wallet-settings branch 3 times, most recently from 8b7544f to ca9845b Compare October 23, 2018 14:16
@jasonrsadler
Copy link
Contributor

Getting a warning when creating wallet from OptIn screen:
Button component not provided an onClick handler as a prop (2 instances)

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Oct 24, 2018 •
edited
Loading

@jasonrsadler this is not related to this PR, but @ryanml fixed it in brave-ui, so is part of new version that will be updated in sep PR

ryanml
ryanml approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and works well!

@NejcZdovc NejcZdovc merged commit 9ff9849 into master Oct 24, 2018
@NejcZdovc NejcZdovc deleted the create-wallet-settings branch October 24, 2018 15:01
NejcZdovc added a commit that referenced this pull request Oct 24, 2018
@NejcZdovc
Merge pull request #712 from brave/create-wallet-settings
06b8446 
Panel fixes
NejcZdovc added a commit that referenced this pull request Oct 24, 2018
@NejcZdovc
Merge pull request #712 from brave/create-wallet-settings
2a4bac4 
Panel fixes
NejcZdovc added a commit that referenced this pull request Oct 24, 2018
@NejcZdovc
Merge pull request #712 from brave/create-wallet-settings
da82010 
Panel fixes
@NejcZdovc
Copy link
Contributor Author

master 9ff9849
0.57.x 06b8446
0.56.x 2a4bac4
0.55.x da82010

@bbondy
Copy link
Member

bbondy commented Oct 30, 2018

Changed merged label to 0.56.x since this won't appear in 0.55.x hotfix2.

@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanml ryanml ryanml approved these changes

@jasonrsadler jasonrsadler Awaiting requested review from jasonrsadler

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.56.x - Release
5 participants
@NejcZdovc @jasonrsadler @bbondy @bridiver @ryanml